Ed448: check for public key presence on export#10656
Merged
Merged
Conversation
holtrop-wolfssl
commented
Jun 10, 2026
|
dgarske
reviewed
Jun 11, 2026
dgarske
left a comment
dgarske
left a comment
Member
There was a problem hiding this comment.
Skoll Code Review
Scan type: reviewOverall recommendation: COMMENT
Findings: 2 total — 2 posted, 0 skipped
1 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [Medium] New PUBLIC_KEY_E return value not documented for wc_ed448_export_public —
wolfcrypt/src/ed448.c:1109-1143, doc/dox_comments/header_files/ed448.h:663-667 - [Low] Public-API semantics change to wc_ed25519_export_key (private-only keys now error) —
wolfcrypt/src/ed25519.c:1523-1537
Review generated by Skoll
Contributor
Author
|
retest this please (Timeout has been exceeded) |
dgarske
reviewed
Jun 12, 2026
dgarske
left a comment
dgarske
left a comment
Member
There was a problem hiding this comment.
Skoll Multi-Scan Review
Modes: review + review-securityOverall recommendation: REQUEST_CHANGES
Findings: 6 total — 6 posted, 0 skipped
4 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [High] [review] Ed448 ToDer test asserts PUBLIC_KEY_E unconditionally; fails under FIPS 7.0.0 —
tests/api/test_ed448.c:503-505 - [High] [review] New wolfCrypt export_key tests assert PUBLIC_KEY_E from export_public without FIPS guard —
wolfcrypt/test/test.c:44905, 46721 - [Low] Public API behavior change: export now returns PUBLIC_KEY_E for private-only keys —
wolfcrypt/src/ed25519.c:1523-1537, wolfcrypt/src/ed448.c:1119-1143 - [Low] New PUBLIC_KEY_E return value not documented for ed448 export functions —
wolfcrypt/src/ed448.c:1109-1118 - [Low] [review] New PUBLIC_KEY_E return of wc_ed448_export_public is undocumented —
wolfcrypt/src/ed448.c:1115-1135 - [Info] [review-security] Intentional public-API return-contract change in wc_ed25519_export_key (private-only keys now yield PUBLIC_KEY_E) —
wolfcrypt/src/ed25519.c:1523-1537
Review generated by Skoll
dgarske
requested changes
Jun 12, 2026
dgarske
left a comment
dgarske
left a comment
Member
There was a problem hiding this comment.
See #10656 (review)
And you have smoke test merge conflicts. Are you use git merge (if so don't). Use git rebase master and a force push
Return PUBLIC_KEY_E for wc_ed25519_export_key if public key is not present. Return PUBLIC_KEY_E for wc_ed448_export_key if public key is not present. Rename several inLen parameters to outLen for consistency. Fix F-4427
dgarske
approved these changes
Jun 12, 2026
Member
|
Jenkins retest this please "Build 'PRB-generic-config-parser' failed with result: FAILURE" . resume.test failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ed448: check for public key presence on export
Return PUBLIC_KEY_E for wc_ed25519_export_key if public key is not present.
Return PUBLIC_KEY_E for wc_ed448_export_key if public key is not present.
Rename several inLen parameters to outLen for consistency.
Fix F-4427
Testing
How did you test?
Checklist